Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Avoid URI filters repercussion in relationship creation forms (#8511) #9066

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Archidoit
Copy link
Member

Proposed changes

Avoid filters repercussion in several screens:

  • Filters in relationship creation form should not be based on the URI
  • Local storage keys should be independant in the different screens of the Knowledge tab of an entity

Related issues

#8511

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Nov 18, 2024
@Archidoit Archidoit self-assigned this Nov 18, 2024
@Archidoit Archidoit changed the title [frontend] Avoid URI filters repercussion in relationship creation form (#8511) [frontend] Avoid URI filters repercussion in relationship creation forms (#8511) Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.68%. Comparing base (aa1d650) to head (79bf800).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9066   +/-   ##
=======================================
  Coverage   64.68%   64.68%           
=======================================
  Files         620      620           
  Lines       59208    59208           
  Branches     6520     6520           
=======================================
  Hits        38301    38301           
  Misses      20907    20907           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Archidoit Archidoit marked this pull request as draft November 19, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knowledge filters are repercuiting in relationship creation entities list
1 participant