Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misp] Error outside the main connector process is not logged #2389

Closed
helene-nguyen opened this issue Jul 22, 2024 · 2 comments · Fixed by #2388
Closed

[Misp] Error outside the main connector process is not logged #2389

helene-nguyen opened this issue Jul 22, 2024 · 2 comments · Fixed by #2388
Assignees
@helene-nguyen
Labels
bug use for describing something not working as expected filigran team use to identify PR from the Filigran team solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.2.8

Comments

@helene-nguyen
Copy link
Member

Description

  • Error outside the main connector process is not logged
  • Issue on indentation

Expected output

  • Have traceback of the error
@helene-nguyen helene-nguyen added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Jul 22, 2024
@helene-nguyen helene-nguyen added this to the Release 6.3.0 milestone Jul 22, 2024
@helene-nguyen helene-nguyen self-assigned this Jul 22, 2024
@helene-nguyen helene-nguyen linked a pull request Jul 22, 2024 that will close this issue
[Misp] Fix indent + add traceback for logs outside connector main process #2388
Merged
4 tasks
@helene-nguyen helene-nguyen mentioned this issue Jul 22, 2024
Merged
4 tasks
@piolug93
Copy link
Contributor

I changed indent because it solves the problem with complex types, such as filename|md5. When indenting is in a loop, it only creates an indicator for filename and bypasses md5.

@helene-nguyen
Copy link
Member Author

@piolug93 Ok, let me check this out and dig into it. There are some issues with the variables when changing the indentation that are not taken into account

@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helene-nguyen helene-nguyen

Labels
bug use for describing something not working as expected filigran team use to identify PR from the Filigran team solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.2.8
3 participants
@SamuelHassine @piolug93 @helene-nguyen