Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake -DEVEL variable #74

Open
chrispbradley opened this issue Jul 1, 2016 · 4 comments
Open

cmake -DEVEL variable #74

chrispbradley opened this issue Jul 1, 2016 · 4 comments

Comments

@chrispbradley
Copy link
Member

This cmake variable should be a boolean i.e., ON/OFF rather than take a number.

@hsorby
Copy link
Contributor

hsorby commented Jul 1, 2016

It takes anything it just needs to be defined. Making it a boolean just gives GUIs a hint as to what widget to display, which isn't any use here as once defined it cannot be changed.

@nickerso
Copy link

nickerso commented Jul 1, 2016

does cmake require it to be set to something or is -DEVEL sufficient?

@chrispbradley
Copy link
Member Author

I think it needs to be set to something. Having it as a boolean gives more clue as to what the possible values are. Having it set to anything is confusing as what value should be used. Every other variable that is a flag is boolean. I'm not sure what makes this one so special that it should be treated differently? @hsorby What happened about the build-a-thon? We changed the time specially for you?

@rondiplomatico
Copy link
Contributor

It takes anything really, boolean or "Otto" if you like. Just "-DEVEL" is not sufficient (my last state). Change the docs to use a boolean if it suits you. Its "so special" since it's only job is to trigger the convenience process of copying the cmakedeveloper-config to the root folder. As cmake adds those vars to the cache if specified on the command line, it would probably be a good idea to remove whatever was set from the cache as soon as the template is copied. Cheerio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants