Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Update the github actions to gate merges to main on succesful compilation, linting, and successful unit tests #4

Closed
alexlovelltroy opened this issue Nov 30, 2023 · 2 comments

Comments

@alexlovelltroy
Copy link
Member

Short Description
The current GitHub Actions come from the HPE team and are not applicable to our setup. We need to set up our own hygiene.

Definition of Done
A successful completion of this task will update the repository configuration and github actions such that they enforce our code quality standards and review requirements.

@synackd
Copy link
Collaborator

synackd commented Nov 30, 2023

We definitely also need to modify the integration tests (and perhaps the GitHub Actions for them) so that the actual tests run. Since none of them currently run right now, all of the tests currently fail in CI.

@synackd synackd moved this to Todo in Roadmap Project Feb 2, 2024
@alexlovelltroy
Copy link
Member Author

We can close this based on the current gating unit tests from dc38761

@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Project Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants