-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] BSS container race condition with docker compose #31
Comments
Looks like the router is initialized before the JWKS fetch. https://github.com/davidallendj/bss/blob/main/cmd/boot-script-service/main.go#L451 |
The code change seems to help, but it also appears to trigger a build error. https://github.com/OpenCHAMI/bss/actions/runs/8983805918 I think it doesn't like the capitalization on the import. OpenCHAMI/jwtauth/v5 might need to be converted to openchami/jwtauth/v5 |
That's odd since SMD has the same import. It looks like the builds for SMD were failing for a different reason as well. |
Yeah. I wasn't sure of the reason. SMD appears to build and upload, but can't seem to attest. It looks like bss fails to build. |
I opened a PR to update the |
I have not observed this during my testing on multiple clusters since the merge of the #33 above. I'm going to close this issue as resolved. If this is still an issue, we can revisit it. |
Describe the bug
BSS seems to not have a good ready state for docker compose while using JWT authentication with hydra. It seems to mark ready when the bss binary is running, not when it's gotten its first token and is ready to serve requests.
To Reproduce
Steps to reproduce the behavior:
Run the quickstart compose.
Expected behavior
I'd expect a different readyness endpoint maybe for when the service is ready to serve requests vs when it's running?
The text was updated successfully, but these errors were encountered: