Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Large directories will break at the IPFS level #639

Closed
JustinDrake opened this issue Aug 21, 2017 · 3 comments
Closed

Large directories will break at the IPFS level #639

JustinDrake opened this issue Aug 21, 2017 · 3 comments
Assignees
Labels
feature Feature or enhancement to openbazaar-go

Comments

@JustinDrake
Copy link
Contributor

As currently setup, large directories will not work. The reason is that sharding is not enabled, and the directory indexes (without sharding) are stored in a single block, which is capped at 1MB. So stores with large listings, ratings, or images directories will break.

It's possible to enable directory sharding but that still hidden behind an experimental flag. In any case, large directories need testing.

@hoffmabc hoffmabc added the feature Feature or enhancement to openbazaar-go label Aug 21, 2017
@hoffmabc
Copy link
Member

@JustinDrake do you have more information on this? Like a reproducible example of this having problems? What happens when it gets to this size currently? Also are there any IPFS open issues on this you can reference?

@JustinDrake
Copy link
Contributor Author

IPFS has a block size limit of 1MB (and libp2p has a block size limit of 2MB), so blocks need to be kept small. Directories right now are a single block, so as they grow the block size will go over the limit, and they will not be fetch-able on the network.

The PR that implemented experimental sharding is ipfs/kubo#3042, and there's discussion for example here ipfs/specs#32

@hoffmabc
Copy link
Member

Ok @cpacia can we do some testing with the flag enabled?

@cpacia cpacia closed this as completed Mar 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature or enhancement to openbazaar-go
Projects
None yet
Development

No branches or pull requests

3 participants