Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that doesn't allow to iterate through tickers with a dot #5489

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes commented Sep 28, 2023

I believe this is the smallest PR I have ever done.

Screenshot 2023-09-27 at 10 52 50 PM

I replicated the routine and made it available on the Hub, so now to test we just need to run:

exe https://my.openbb.co/u/undefined/routine/fix-bug-5489

@Disorrder you are the regex guru, can you have a look at this?

@DidierRLopes DidierRLopes added the bug Fix bug label Sep 28, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Sep 28, 2023
@jmaslek jmaslek added this pull request to the merge queue Sep 28, 2023
Merged via the queue into develop with commit 40ae229 Sep 28, 2023
28 of 36 checks passed
@piiq piiq deleted the hotfix/routine-with-loop-accepting-dot branch September 29, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants