Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix / improve autoscaling/dynamic loading, fix forex candle charts, equity reports #5183

Merged
merged 27 commits into from
Jul 14, 2023

Conversation

tehcoderer
Copy link
Contributor

@tehcoderer tehcoderer commented Jun 25, 2023

closes #5187 closes #5179 closes #5171 closes #5151 close #5182

@reviewpad reviewpad bot added the feat L Large T-Shirt size Feature label Jun 25, 2023
@deeleeramone
Copy link
Contributor

Pretty good edge case here, load usdjpy --start 2023-06-23 --interval 5min --source Polygon

Screenshot 2023-06-26 172043

@deeleeramone
Copy link
Contributor

AlphaVantage:

image

@deeleeramone
Copy link
Contributor

Great solution on cutting the gaps.

Screenshot 2023-06-28 at 12 32 15 PM

/stocks/candle localizes Forex data properly, but /forex/candle is in UTC. Can the Forex menu work like the Stocks can?

Screenshot 2023-06-28 at 12 33 58 PM

@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat L Large T-Shirt size Feature labels Jun 28, 2023
@tehcoderer
Copy link
Contributor Author

Great solution on cutting the gaps.

Screenshot 2023-06-28 at 12 32 15 PM

/stocks/candle localizes Forex data properly, but /forex/candle is in UTC. Can the Forex menu work like the Stocks can?

Screenshot 2023-06-28 at 12 33 58 PM

doneeee

@deeleeramone
Copy link
Contributor

it's been localized, but now the new data for today has stopped collecting.

Screenshot 2023-06-28 at 6 58 18 PM

@deeleeramone
Copy link
Contributor

Screenshot 2023-06-28 at 7 06 23 PM

@tehcoderer
Copy link
Contributor Author

Screenshot 2023-06-28 at 7 06 23 PM

???
image

@tehcoderer
Copy link
Contributor Author

@deeleeramone figured it out, added a +1 day to end date since some sources use UTC date for query

@tehcoderer tehcoderer added the do not merge Label to prevent pull request merge label Jul 3, 2023
@jmaslek jmaslek removed the do not merge Label to prevent pull request merge label Jul 14, 2023
@jmaslek jmaslek enabled auto-merge July 14, 2023 14:45
@jmaslek jmaslek added this pull request to the merge queue Jul 14, 2023
Merged via the queue into OpenBB-finance:develop with commit 281799f Jul 14, 2023
jmaslek added a commit to jmaslek/OpenBBTerminal that referenced this pull request Jul 14, 2023
…, equity reports (OpenBB-finance#5183)

* improve autoscaling/dynamic loading, fix forex candle charts

* updates

* Update plotly_helper.py

* fix?

* fix table date sorting, localize forex load

* tests

* tests?

* ugh tests

* Update test_display_debt.txt

* Update test_get_debt.csv

* Update forex_helper.py

* close OpenBB-finance#5182

* fix `crypto/dd/info` tables not loading due to `dict` object in dataframe values

* Update parent_classes.py

* tables: show full value on hover, fix year only filtering. on reset use queue if logged in

* lint + first batch of test fix

* tests pt2

* Tests v3

* Pylint

* typo

---------

Co-authored-by: James Maslek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment