Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/usd-liquidity-index: Adds USD Liquidity Index to Economy menu #5174

Merged
merged 16 commits into from
Jul 6, 2023

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Jun 23, 2023

Description

  • Summary of the change / bug fix.

Frequently requested item, USD Liquidity Index. Updated weekly and published to FRED, it is: WALCL - WLRRAL - WDTGAL

/economy/usdli
openbb.economy.usdli
openbb.economy.usdli_chart

  • Screenshot of the feature or the bug before/after fix, if applicable.
USD.Liquidity.Index.mov
In [1]: from openbb_terminal.sdk import openbb

In [2]: openbb.economy.usdli()
Out[2]: 
            USD Liquidity Index (Billions of USD)  S&P 500 Index
2013-06-26                                3295.71        1603.26
2013-07-03                                3294.82        1615.41
2013-07-10                                3342.94        1652.62
2013-07-17                                3382.18        1680.91
2013-07-24                                3438.05        1685.94
...                                           ...            ...
2023-05-24                                5775.78        4115.24
2023-05-31                                5721.66        4179.83
2023-06-07                                5803.75        4267.52
2023-06-14                                5816.40        4372.59
2023-06-21                                5699.68        4365.69

[516 rows x 2 columns]

Screenshot 2023-06-22 at 10 29 42 PM

How has this been tested?

  • Please describe the tests that you ran to verify your changes.

The changes rely on existing FRED functions to pull data by Series ID.

  • Added to integration test for the economy menu.
  • Updated test_economy_controller
  • Added tests to tests/openbb_terminal/economy/test_fred_model.py

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@deeleeramone deeleeramone added the enhancement Enhancement label Jun 23, 2023
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Jun 23, 2023
@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat M Medium T-Shirt size feature labels Jun 24, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Jul 5, 2023

Should also be added to askobb. @martinb-bb can provide guidance if needed

@martinb-ai
Copy link
Contributor

@jmaslek done
image

@jmaslek
Copy link
Collaborator

jmaslek commented Jul 5, 2023

Can you ask @tehcoderer how to get rid of both major gridlines:

Screenshot 2023-07-05 at 5 16 32 PM

@deeleeramone
Copy link
Contributor Author

deeleeramone commented Jul 5, 2023

Can you ask @tehcoderer how to get rid of both major gridlines:

easy breezy. do you want the X-Grid gone too?

Screenshot 2023-07-05 at 2 21 53 PM

Without:

Screenshot 2023-07-05 at 2 25 49 PM

@jmaslek
Copy link
Collaborator

jmaslek commented Jul 5, 2023

Can you ask @tehcoderer how to get rid of both major gridlines:

easy breezy. do you want the X-Grid gone too?

Screenshot 2023-07-05 at 2 21 53 PM

I like the major grid, but only for the main (right) axis. Not too overlapped one

@deeleeramone
Copy link
Contributor Author

I like the major grid, but only for the main (right) axis. Not too overlapped one

So like this?

Screenshot 2023-07-05 at 2 29 01 PM

Would be pretty cool to have an on-chart setting for grid on/off.

@deeleeramone
Copy link
Contributor Author

Personally I like it less busy, with just the horizontals.

Screenshot 2023-07-05 at 2 31 36 PM

@jmaslek
Copy link
Collaborator

jmaslek commented Jul 5, 2023

I like the major grid, but only for the main (right) axis. Not too overlapped one

So like this?

Screenshot 2023-07-05 at 2 29 01 PM

Would be pretty cool to have an on-chart setting for grid on/off.

Dis one

@tehcoderer
Copy link
Contributor

SHIP IT

@jmaslek jmaslek added this pull request to the merge queue Jul 6, 2023
Merged via the queue into develop with commit 8df31f8 Jul 6, 2023
@piiq piiq deleted the feature/usd-liquidity-index branch July 12, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants