Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive improvements to askobb v0.3 #5150

Merged
merged 7 commits into from
Jun 19, 2023
Merged

Conversation

martinb-ai
Copy link
Contributor

Steps to make doc changes and test:

  1. Add or modify docs withinopenbb_terminal/miscellaneous/gpt_index/data
  2. Delete openbb_terminal/miscellaneous/gpt_index/index_0.23.json

Restart terminal, and re-ask. (it automatically regenerates the new embedding json)
If there is substantial improvements, commit the GPT_INDEX_VER along with the jsons.

Please provide any prompt/question edge cases below.

Edge cases

  • unemployment rate in united states.

Topics to improve (WIP):

  • use askobb from anywhere in the terminal

Yes, @jmaslek you can modify data/*txts for the index.

@reviewpad reviewpad bot added the feat XS Extra small feature label Jun 19, 2023
@martinb-ai martinb-ai requested review from jmaslek and removed request for jmaslek June 19, 2023 15:31
@martinb-ai martinb-ai marked this pull request as draft June 19, 2023 15:32
@martinb-ai martinb-ai requested a review from jmaslek June 19, 2023 15:32
@martinb-ai martinb-ai changed the title Progressive improvements to askobb v2 Progressive improvements to askobb v0.24 Jun 19, 2023
@martinb-ai martinb-ai changed the title Progressive improvements to askobb v0.24 Progressive improvements to askobb v0.3 Jun 19, 2023
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Jun 19, 2023
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat S Small T-Shirt size Feature labels Jun 19, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Jun 19, 2023

Moved this function to the BaseController so that it is accessible from any terminal menu. However, this does not provide any additional information to the LLM.

@martinb-ai martinb-ai marked this pull request as ready for review June 19, 2023 17:12
@jmaslek jmaslek added this pull request to the merge queue Jun 19, 2023
Merged via the queue into develop with commit bf33211 Jun 19, 2023
@piiq piiq deleted the feature/askobb-improv-v2 branch July 12, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants