Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move askobb to cmd and change question to prompt #5141

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Move askobb to cmd and change question to prompt #5141

merged 3 commits into from
Jun 14, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Jun 14, 2023

Title says it all:

  • Change askobb to appear as a cmd
  • Change -q/--question to -q/--prompt
  • Allow two words (ie aapl candle) as a prompt

@jmaslek jmaslek requested a review from DidierRLopes June 14, 2023 20:03
@reviewpad reviewpad bot added the feat XS Extra small feature label Jun 14, 2023
@jmaslek jmaslek added this pull request to the merge queue Jun 14, 2023
Merged via the queue into develop with commit 250a782 Jun 14, 2023
@piiq piiq deleted the feature/askobb-cmd branch July 12, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DidierRLopes DidierRLopes DidierRLopes approved these changes

Assignees
No one assigned
Labels
feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaslek @DidierRLopes