Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes stocks/fa integration test file #5092

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

deeleeramone
Copy link
Contributor

This fixes a bunch of bad syntax that was in the stocks/fa integration test file. Oddly enough, when I execute the test locally, it returns an error for an item that is not actually in the test.

image

Removing any reference to balance and YahooFinance creates a new error, which again is never referenced in the test file.

image

Every command in the .openbb file works and produces an output, so this is half bug report and half PR. :P

@deeleeramone deeleeramone added bug Fix bug tests Test-related work labels May 31, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label May 31, 2023
Copy link
Contributor

@IgorWounds IgorWounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@jmaslek jmaslek enabled auto-merge June 1, 2023 20:09
@jmaslek jmaslek added this pull request to the merge queue Jun 1, 2023
Merged via the queue into develop with commit eac108e Jun 1, 2023
@piiq piiq deleted the hotfix/fix-fa-integration-test branch June 4, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants