Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/docs-sdk-basics: Updates SDK basics page. #5024

Merged
merged 16 commits into from
May 23, 2023

Conversation

deeleeramone
Copy link
Contributor

This PR updates the SDK basics page to be current.

@deeleeramone deeleeramone added docs Code documentation guides Guides and online documentation platform OpenBB Platform labels May 15, 2023
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label May 15, 2023
@deeleeramone
Copy link
Contributor Author

@jmaslek - I removed three pages, incorporating them into the basics page. Do you agree with this choice?

@jmaslek
Copy link
Collaborator

jmaslek commented May 17, 2023

@jmaslek - I removed three pages, incorporating them into the basics page. Do you agree with this choice?

Think that makes sense to delete those pages. What doesn't make sense is having the same api-keys.md page twice (except for how to set).

But that is out of the scope here. Will look at this shotly

Comment on lines +11 to +13
## Overview

Now that you have the SDK installed, the first step is to import the OpenBB SDK in your preferred code editor. Nearly everything required to interact with any function from the OpenBB Terminal gets imported in one line. Begin a Python script or Notebook file with:
The OpenBB SDK provides programmatic access to nearly all Terminal commands, allowing custom scripts and functions to power creations built on top of the core platform. It is easy to use and as flexible as one's imagination. The sections below will outline how to get started using it. If it isn't already installed, follow the instructions to install via [PyPi (pip)](https://docs.openbb.co/terminal/installation/pypi) or from the [source code](https://docs.openbb.co/terminal/installation/source).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should probably differentiate that the sdk itself (without all) can be installed pretty much anywhere? I can just fire up a venv, run pip install openbb and I am good to go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmm...that would mean we are telling people to install the Terminal this way, and we still want people to install by following the instructions so they don't make up their own methods and complain when "pip install doesn't work".

I think I have some install steps for Google CoLab that are now stable.

Copy link
Contributor Author

@deeleeramone deeleeramone May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the ideal spot for these instructions... thoughts?

@deeleeramone
Copy link
Contributor Author

What doesn't make sense is having the same api-keys.md page twice (except for how to set).

Ya, that was a discussion with @DidierRLopes during the Hub push, and we'll have to think of a better solution for this instead of maintaining two separate pages.

@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat M Medium T-Shirt size feature labels May 17, 2023
Comment on lines 20 to 24
The steps below assume that the developer container is Ubuntu-based. If using Google Colab, remove `sudo` from the commands.

**Step 1**: `sudo apt update && sudo apt upgrade`
**Step 2**: `sudo apt install libwebkit2gtk-4.0-dev`
**Step 3**: `pip install openbb`, or, `pip install openbb[optimization]`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colab can be done with a single line !pip install openbb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to launch it without the warning messages, then you need to install libwebkit.

@jmaslek
Copy link
Collaborator

jmaslek commented May 18, 2023

One of the things that I am not seeing anywhere is the fact that all the base functionalities can be run using :

python -m venv test
source test/bin/activate
pip install openbb

@deeleeramone
Copy link
Contributor Author

One of the things that I am not seeing anywhere is the fact that all the base functionalities can be run using :

python -m venv test
source test/bin/activate
pip install openbb

Shouldn't these things be on the installation page?

@jmaslek
Copy link
Collaborator

jmaslek commented May 18, 2023

One of the things that I am not seeing anywhere is the fact that all the base functionalities can be run using :

python -m venv test
source test/bin/activate
pip install openbb

Shouldn't these things be on the installation page?

Yeah. I guess out of scope here. Will leave up to you

@jmaslek jmaslek added this pull request to the merge queue May 23, 2023
Merged via the queue into develop with commit e202aeb May 23, 2023
@piiq piiq deleted the hotfix/docs-sdk-basics branch June 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation feat L Large T-Shirt size Feature guides Guides and online documentation platform OpenBB Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants