Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds type to the version on the SystemModel #4944

Merged

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented May 1, 2023

^

So that version shows up no the logs.

Before:

SYSTEM: {"OS": "Linux", "PYTHON_VERSION": "3.9.13", "PLATFORM": "my-platform", "LOGGING_APP_ID": "my-app-id", "LOGGING_APP_NAME": "gst", "LOGGING_COMMIT_HASH": "REPLACE_ME", "LOGGING_FREQUENCY": "H", "LOGGING_HANDLERS": "file", "LOGGING_ROLLING_CLOCK": false, "LOGGING_VERBOSITY": 20, "LOGGING_SUB_APP": "terminal", "LOGGING_SUPPRESS": false, "LOG_COLLECT": false, "DISABLE_STREAMLIT_WARNING": true, "DISABLE_FORECASTING_WARNING": true, "DISABLE_OPTIMIZATION_WARNING": true, "TEST_MODE": false, "DEBUG_MODE": false, "ENABLE_AUTHENTICATION": true, "HEADLESS": false} 

After:

SYSTEM: {"OS": "Linux", "PYTHON_VERSION": "3.9.13", "PLATFORM": "my-platform", "VERSION": "3.0.0", "LOGGING_APP_ID": "my-app-id", "LOGGING_APP_NAME": "gst", "LOGGING_COMMIT_HASH": "REPLACE_ME", "LOGGING_FREQUENCY": "H", "LOGGING_HANDLERS": "file", "LOGGING_ROLLING_CLOCK": false, "LOGGING_VERBOSITY": 20, "LOGGING_SUB_APP": "terminal", "LOGGING_SUPPRESS": false, "LOG_COLLECT": false, "DISABLE_STREAMLIT_WARNING": true, "DISABLE_FORECASTING_WARNING": true, "DISABLE_OPTIMIZATION_WARNING": true, "TEST_MODE": false, "DEBUG_MODE": false, "ENABLE_AUTHENTICATION": true, "HEADLESS": false} 

@hjoaquim hjoaquim added the bug Fix bug label May 1, 2023
@hjoaquim hjoaquim requested a review from jmaslek May 1, 2023 20:15
@reviewpad reviewpad bot added the feat XS Extra small feature label May 1, 2023
@jmaslek jmaslek enabled auto-merge May 1, 2023 20:16
@jmaslek jmaslek added this pull request to the merge queue May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 28.09% and project coverage change: -0.18 ⚠️

Comparison is base (df9a154) 58.29% compared to head (c9cb2fa) 58.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4944      +/-   ##
===========================================
- Coverage    58.29%   58.11%   -0.18%     
===========================================
  Files          588      588              
  Lines        53666    53708      +42     
===========================================
- Hits         31283    31212      -71     
- Misses       22383    22496     +113     
Impacted Files Coverage Δ
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...bb_terminal/core/sdk/models/portfolio_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <ø> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
...bb_terminal/dashboards/stream/streamlit_helpers.py 0.00% <0.00%> (ø)
... and 17 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Merged via the queue into OpenBB-finance:develop with commit 25b8bd9 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants