-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds options helper function for DTE, updates SDK trail map to not use yFinance. #4937
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4937 +/- ##
===========================================
- Coverage 58.29% 58.10% -0.19%
===========================================
Files 588 588
Lines 53666 53716 +50
===========================================
- Hits 31283 31214 -69
- Misses 22383 22502 +119
☔ View full report in Codecov by Sentry. |
@@ -594,3 +594,20 @@ def Vomma(self, change): | |||
* norm.pdf(self.d1) | |||
/ self._sigma | |||
) | |||
|
|||
|
|||
@log_start_end(log=logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this logger. Will pollute with unhelpful START END messaged
Adds a new helper function in
openbb_terminal/stocks/options/op_helpers.py
for appending the chain DataFrame with a column for DTE.This PR updates the SDK so that:
openbb_terminal.stocks.options.op_helpers
is a valid SDK path.openbb.stocks.options.DTE
to come from theop_helpers
.The docstring has been updated:
It works with all sources, relying on there being a called called:
expiration
.