Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crypto/dd/rm command #4890

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Fix crypto/dd/rm command #4890

merged 5 commits into from
Apr 26, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Apr 25, 2023 •
edited
Loading

Screenshot 2023-04-25 at 12 13 23

Fixed
Screenshot 2023-04-25 at 12 11 07

@montezdesousa montezdesousa added the bug Fix bug label Apr 25, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 43.24% and project coverage change: -0.15 ⚠️

Comparison is base (a1aff50) 58.43% compared to head (88aec6b) 58.29%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4890      +/-   ##
===========================================
- Coverage    58.43%   58.29%   -0.15%     
===========================================
  Files          588      588              
  Lines        53608    53660      +52     
===========================================
- Hits         31328    31281      -47     
- Misses       22280    22379      +99
Impacted Files Coverage Δ
generate_sdk.py 90.82% <ø> (ø)
openbb_terminal/account/account_controller.py 81.02% <0.00%> (-1.78%) ⬇️
...mmon/technical_analysis/custom_indicators_model.py 20.83% <0.00%> (ø)
...minal/common/technical_analysis/volatility_view.py 32.81% <ø> (ø)
...lots/plotly_ta/plugins/custom_indicators_plugin.py 14.13% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/session/routines_handler.py 63.52% <0.00%> (-20.02%) ⬇️
...minal/cryptocurrency/due_diligence/messari_view.py 24.12% <ø> (+0.12%) ⬆️
...b_terminal/econometrics/econometrics_controller.py 47.40% <ø> (ø)
openbb_terminal/featflags_controller.py 84.81% <ø> (-3.15%) ⬇️
... and 28 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@montezdesousa montezdesousa requested a review from hjoaquim April 25, 2023 14:01
@hjoaquim hjoaquim enabled auto-merge April 26, 2023 09:01
@hjoaquim hjoaquim added this pull request to the merge queue Apr 26, 2023
Merged via the queue into develop with commit 0d7318b Apr 26, 2023
jmaslek pushed a commit that referenced this pull request Apr 27, 2023
@montezdesousa @hjoaquim @jmaslek
fix rm command (#4890)
839638b 
Co-authored-by: Henrique Joaquim <[email protected]>
jmaslek added a commit that referenced this pull request Apr 28, 2023
@jose-donato @jmaslek
@tehcoderer @montezdesousa @hjoaquim
Adds shroom command and removes old ones (#4246)
c603a36 
* fix: remove old commands

* fix: ruff

* fix: ruff

* fix: james suggestions

* fix: added to csv

* fix: generate sdk cmds

* bump pywry

* fix rm command (#4890)

Co-authored-by: Henrique Joaquim <[email protected]>

* Fix `crypto/defi/anchor` (#4892)

* handle defi anchor exceptions

* reason

* mypy

---------

Co-authored-by: Henrique Joaquim <[email protected]>

* fix windows pyinstaller subprocess fail if space in path

* remove API_IEX_TOKEN

* remove API_SENTIMENTINVESTOR_TOKEN

* make -h actually work

* black ./

---------

Co-authored-by: James Maslek <[email protected]>
Co-authored-by: teh_coderer <[email protected]>
Co-authored-by: montezdesousa <[email protected]>
Co-authored-by: Henrique Joaquim <[email protected]>
@jmaslek jmaslek deleted the hotfix/fix_cryptorm branch May 1, 2023 20:57
jmaslek added a commit that referenced this pull request May 4, 2023
@jmaslek @tehcoderer
@montezdesousa @hjoaquim
Hotfix/kill cov (#4971)
aa72d4a 
* bump pywry

* fix rm command (#4890)

Co-authored-by: Henrique Joaquim <[email protected]>

* Fix `crypto/defi/anchor` (#4892)

* handle defi anchor exceptions

* reason

* mypy

---------

Co-authored-by: Henrique Joaquim <[email protected]>

* fix windows pyinstaller subprocess fail if space in path

* remove API_IEX_TOKEN

* remove API_SENTIMENTINVESTOR_TOKEN

* remove codecov

---------

Co-authored-by: teh_coderer <[email protected]>
Co-authored-by: montezdesousa <[email protected]>
Co-authored-by: Henrique Joaquim <[email protected]>
hjoaquim added a commit that referenced this pull request May 9, 2023
@jmaslek @tehcoderer
@montezdesousa @hjoaquim
Hotfix/databento + bugs (#4973)
425b740 
* bump pywry

* fix rm command (#4890)

Co-authored-by: Henrique Joaquim <[email protected]>

* Fix `crypto/defi/anchor` (#4892)

* handle defi anchor exceptions

* reason

* mypy

---------

Co-authored-by: Henrique Joaquim <[email protected]>

* fix windows pyinstaller subprocess fail if space in path

* remove API_IEX_TOKEN

* remove API_SENTIMENTINVESTOR_TOKEN

* Fix data bento calls

* Fix options eod chain bug

* Fix finviz get

* Fix yf balance bug

* removing breakline

* Add error message

---------

Co-authored-by: teh_coderer <[email protected]>
Co-authored-by: montezdesousa <[email protected]>
Co-authored-by: Henrique Joaquim <[email protected]>
jmaslek added a commit that referenced this pull request May 10, 2023
@northern-64bit @jmaslek
@tehcoderer @montezdesousa @hjoaquim @andrewkenreich
Adding GARCH (#4815)
bde21f0 
* Add GARCH

* Linting

* Rearrange the econometrics menu

* Add integration test

* Add ret command + fixes

* Fix linting

* Fix linting

* Fix pylint

* Add logger to functions

* bump pywry

* fix rm command (#4890)

Co-authored-by: Henrique Joaquim <[email protected]>

* Fix `crypto/defi/anchor` (#4892)

* handle defi anchor exceptions

* reason

* mypy

---------

Co-authored-by: Henrique Joaquim <[email protected]>

* fix windows pyinstaller subprocess fail if space in path

* remove API_IEX_TOKEN

* remove API_SENTIMENTINVESTOR_TOKEN

* Convert to latex + requested changes

* Fix linting

* Remove unnecessary logger

* Add example

* SDK updated

* fix syntax on elite level math that I def know

* Fix docstring

* Fix example

* Fix

* Linting

---------

Co-authored-by: James Maslek <[email protected]>
Co-authored-by: teh_coderer <[email protected]>
Co-authored-by: montezdesousa <[email protected]>
Co-authored-by: Henrique Joaquim <[email protected]>
Co-authored-by: andrewkenreich <[email protected]>
jmaslek added a commit that referenced this pull request May 10, 2023
@marban @jmaslek
@tehcoderer @montezdesousa @hjoaquim @minhhoang1023
First introduction of news_biztoc — A new partnership with BizToc.com (…
29a297c 
…#4864)

* First introduction of news_biztoc — A new partnership with BizToc.com

* bump pywry

* fix rm command (#4890)

Co-authored-by: Henrique Joaquim <[email protected]>

* Fix `crypto/defi/anchor` (#4892)

* handle defi anchor exceptions

* reason

* mypy

---------

Co-authored-by: Henrique Joaquim <[email protected]>

* fix windows pyinstaller subprocess fail if space in path

* remove API_IEX_TOKEN

* remove API_SENTIMENTINVESTOR_TOKEN

* Add autocompletion and merge into one news function + add to sources dictionary

* Autocomplete for the tag

* fix test

* Make a new sdk help[er for openbb.news

* pylint

* lint

* lint2

* Regenerate sdk

* remove cmd from list

* api-keys

* Update api-keys.md

Add images

---------

Co-authored-by: James Maslek <[email protected]>
Co-authored-by: teh_coderer <[email protected]>
Co-authored-by: montezdesousa <[email protected]>
Co-authored-by: Henrique Joaquim <[email protected]>
Co-authored-by: minhhoang1023 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

@jose-donato jose-donato Awaiting requested review from jose-donato

Assignees
No one assigned
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montezdesousa @hjoaquim