-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --std
argument in bbands command
#4866
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4866 +/- ##
===========================================
- Coverage 58.29% 58.08% -0.21%
===========================================
Files 588 588
Lines 53666 53687 +21
===========================================
- Hits 31283 31184 -99
- Misses 22383 22503 +120
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue (#4932) regarding the overlap, which already has a pr linked to it now. Shall we merge this and then adjust possibly adjust it and add a legend for each trace after #4941? The pr fixes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Closing #4863.
Makes the
--std
parameter actually influence the output and fixes the handling of float inputs.How has this been tested?
Running the command with float inputs and assuring that the result varies.
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others