Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed search command issues #4845

Merged
merged 18 commits into from
May 5, 2023
Merged

Fixed search command issues #4845

merged 18 commits into from
May 5, 2023

Conversation

the-praxs
Copy link
Contributor

Fixes #4833

@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 43.82% and project coverage change: -0.21 ⚠️

Comparison is base (df9a154) 58.29% compared to head (bd1dad4) 58.08%.

❗ Current head bd1dad4 differs from pull request most recent head 50e5682. Consider uploading reports for the commit 50e5682 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4845      +/-   ##
===========================================
- Coverage    58.29%   58.08%   -0.21%     
===========================================
  Files          588      588              
  Lines        53666    53686      +20     
===========================================
- Hits         31283    31182     -101     
- Misses       22383    22504     +121
Impacted Files Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...bb_terminal/core/sdk/models/portfolio_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
... and 26 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@the-praxs
Copy link
Contributor Author

@jmaslek please review this, thanks!

@the-praxs
Copy link
Contributor Author

@jmaslek please review this, thanks!

jmaslek
jmaslek reviewed May 2, 2023
View reviewed changes
openbb_terminal/stocks/stocks_controller.py Outdated
@@ -197,7 +197,7 @@ def call_search(self, other_args: List[str]):
help="Search by sector to find stocks matching the criteria",
)
parser.add_argument(
"-g",
"--ig",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for both. Can just have industry-group. Same for below.

Copy link
Contributor Author

@the-praxs the-praxs May 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it because industry-group and exchange-country do not list/autosuggest the options. Any suggestions on how to resolve this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am not sure why. I pushed a proposed solution just calling it industrygroup and exchangecountry instead of any separator. Seems to work. Let me know if thats all good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will modify the tests and push the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are good. Everything works!

@jmaslek jmaslek added this pull request to the merge queue May 5, 2023
Merged via the queue into OpenBB-finance:develop with commit 5ed7830 May 5, 2023
@the-praxs the-praxs deleted the hotfix/4833 branch May 8, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeleeramone deeleeramone deeleeramone left review comments

@jmaslek jmaslek jmaslek approved these changes

Assignees
No one assigned
Labels
feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] stocks/search -e asx: no companies found. + other issues
4 participants
@the-praxs @jmaslek @deeleeramone @hjoaquim