Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix #4710

Merged
merged 11 commits into from
Apr 10, 2023
Merged

Added fix #4710

merged 11 commits into from
Apr 10, 2023

Conversation

the-praxs
Copy link
Contributor

Fixed #4707

How has this been tested?

Tested by executing the terminal application in Python
and running the commands with the arguments.

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 7, 2023
@deeleeramone
Copy link
Contributor

@jmaslek, is it best to remove the line entirely, instead of simply commenting it out? This does indeed resolve the issue.

@deeleeramone deeleeramone mentioned this pull request Apr 8, 2023
11 tasks
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@8413d30). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4710   +/-   ##
==========================================
  Coverage           ?   57.56%           
==========================================
  Files              ?      589           
  Lines              ?    53858           
  Branches           ?        0           
==========================================
  Hits               ?    31001           
  Misses             ?    22857           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@the-praxs
Copy link
Contributor Author

the-praxs commented Apr 8, 2023

@jmaslek, is it best to remove the line entirely, instead of simply commenting it out? This does indeed resolve the issue.

I did want to remove the lines because they serve no purpose there, functionality or debugging-wise. There's no need to use the required parameter because -h and --help does not preclude any other arguments and should run independently.

If you want I can resubmit the PR with these lines removed.

@hjoaquim hjoaquim mentioned this pull request Apr 8, 2023
15 tasks
@the-praxs
Copy link
Contributor Author

@hjoaquim made the same changes and submitted for review.

Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🚀

@hjoaquim hjoaquim enabled auto-merge April 10, 2023 08:28
@hjoaquim hjoaquim added this pull request to the merge queue Apr 10, 2023
Merged via the queue into OpenBB-finance:develop with commit 96d21f7 Apr 10, 2023
@the-praxs the-praxs deleted the hotfix/4707 branch April 10, 2023 11:00
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* Added fix

* Fixed `load`, `find`, `price` and refactored code

* Modified line 1304 in parent_classes.py

---------

Co-authored-by: Danglewood <[email protected]>
Co-authored-by: Henrique Joaquim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] crypto/find --help - find: error: the following arguments are required: -c/--coin
3 participants