-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix #4710
Added fix #4710
Conversation
@jmaslek, is it best to remove the line entirely, instead of simply commenting it out? This does indeed resolve the issue. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4710 +/- ##
==========================================
Coverage ? 57.56%
==========================================
Files ? 589
Lines ? 53858
Branches ? 0
==========================================
Hits ? 31001
Misses ? 22857
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I did want to remove the lines because they serve no purpose there, functionality or debugging-wise. There's no need to use the required parameter because If you want I can resubmit the PR with these lines removed. |
@hjoaquim made the same changes and submitted for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 🚀
* Added fix * Fixed `load`, `find`, `price` and refactored code * Modified line 1304 in parent_classes.py --------- Co-authored-by: Danglewood <[email protected]> Co-authored-by: Henrique Joaquim <[email protected]>
Fixed #4707
load
,find
,price
commands.crypto/find --help
- find: error: the following arguments are required: -c/--coin #4707How has this been tested?
Tested by executing the terminal application in Python
and running the commands with the arguments.
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others