Feature/In-Chart Volume, Streamlit TA Indicators

.gitattributes

@@ -1,2 +1,3 @@
 * linguist-vendored
 *.py linguist-vendored=false
+text eol=lf

.github/workflows/unit-test.yml

@@ -82,6 +82,7 @@ jobs:
 
       - name: Setup sudo apt installs for ubuntu-latest
         run: |
+          curl --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable
           sudo apt-get update
           sudo apt-get install -y \
               build-essential \
@@ -159,6 +160,7 @@ jobs:
 
       - name: Setup sudo apt installs for ubuntu-latest
         run: |
+          curl --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable
           sudo apt-get update
           sudo apt-get install -y \
               build-essential \
@@ -241,6 +243,7 @@ jobs:
       - name: Setup sudo apt installs for ubuntu-latest
         if: runner.os == 'Linux'
         run: |
+          curl --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable
           sudo apt-get update
           sudo apt-get install -y \
               build-essential \
@@ -321,6 +324,7 @@ jobs:
       - name: Setup sudo apt installs for ubuntu-latest
         if: runner.os == 'Linux'
         run: |
+          curl --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable
           sudo apt-get update
           sudo apt-get install -y \
               build-essential \

openbb_terminal/alternative/covid/covid_view.py

@@ -160,6 +160,7 @@ def display_covid_ov(
     export: str = "",
     sheet_name: Optional[str] = None,
     plot: bool = True,
+    external_axes: bool = False,
 ) -> Union[OpenBBFigure, None]:
     """Prints table showing historical cases and deaths by country.
 
@@ -177,6 +178,8 @@ def display_covid_ov(
         Format to export data
     plot: bool
         Flag to display historical plot
+    external_axes : bool, optional
+        Whether to return the figure object or not, by default False
     """
     fig = OpenBBFigure()
 
@@ -207,7 +210,7 @@ def display_covid_ov(
             fig,
         )
 
-    return fig.show(external=raw)
+    return fig.show(external=raw or external_axes)
 
 
 @log_start_end(log=logger)

openbb_terminal/common/quantitative_analysis/qa_view.py

@@ -265,6 +265,7 @@ def display_bw(
     >>> df = openbb.stocks.load("AAPL")
     >>> openbb.qa.bw(data=df, target="Adj Close")
     """
+    data = data.copy()
     start = data[target].index[0]
 
     color = theme.get_colors()[0]
@@ -288,7 +289,10 @@ def display_bw(
     ]
 
     fig = OpenBBFigure(
-        title=f"{['Monthly','Yearly'][yearly]} box plot of {symbol} {target} from {start.strftime('%Y-%m-%d')}",
+        title=(
+            f"{['Monthly','Yearly'][yearly]} box plot of {symbol.upper()} "
+            f"{target} from {start.strftime('%Y-%m-%d')}"
+        ),
         yaxis_title=target,
         xaxis_title=["Monthly", "Yearly"][yearly],
     )

openbb_terminal/common/technical_analysis/custom_indicators_view.py

@@ -99,7 +99,7 @@ def plot_multiple_indicators(
     data: pd.DataFrame,
     indicators: List[str],
     symbol: str = "",
-    window: Optional[List[int]] = None,
+    params: Optional[dict] = None,
     export: str = "",
     sheet_name: Optional[str] = None,
     external_axes: bool = False,
@@ -135,15 +135,15 @@ def plot_multiple_indicators(
     if ta_helpers.check_columns(data) is None:
         return None
 
-    if window is None:
-        window = [20, 50]
-
     indicators_dict: dict = {indicator: {} for indicator in indicators}
+    if params:
+        indicators_dict.update(params)
+
     ta = PlotlyTA()
 
     for ma in ta.ma_mode:
-        if ma in indicators_dict:
-            indicators_dict[ma] = dict(length=window)
+        if ma in indicators_dict and not indicators_dict[ma].get("length", None):
+            indicators_dict[ma] = dict(length=[20, 50])
 
     fig = ta.plot(
         data,

openbb_terminal/core/completer/choices.py

@@ -91,7 +91,6 @@ def __mock_parse_known_args_and_warn(
             default=sources[0],  # the first source from the list is the default
             help="Data source to select from",
         )
-    return None
 
 
 def __mock_parse_simple_args(parser: ArgumentParser, other_args: List[str]) -> None:
@@ -110,8 +109,6 @@ def __mock_parse_simple_args(parser: ArgumentParser, other_args: List[str]) -> N
     )
     _ = other_args
 
-    return None
-
 
 def __get_command_func(controller, command: str):
     """Get the function with the name `f"call_{command}"` from controller object.

openbb_terminal/core/config/paths_helper.py

@@ -67,7 +67,7 @@ def init_userdata():
     """
     Initializes the user data folder
     """
-    global initialized
+    global initialized  # noqa
     if not initialized:
         create_paths(dirs_list)
         create_files(dirs_files)

openbb_terminal/core/plots/backend.py

@@ -383,7 +383,7 @@ async def download_plotly_js():
 
 def plots_backend() -> Backend:
     """Get the backend."""
-    global BACKEND  # pylint: disable=W0603
+    global BACKEND  # pylint: disable=W0603 # noqa
     if BACKEND is None:
         BACKEND = Backend()
     return BACKEND

openbb_terminal/core/plots/plotly.html

@@ -91,7 +91,11 @@
         // calling OpenBBMain to avoid errors
         if (typeof OpenBBMain != "undefined" && window.plotly_figure) {
           clearInterval(interval);
-          OpenBBMain(window.plotly_figure, document.getElementById("openbb_chart"));
+          CHART_DIV = document.getElementById("openbb_chart");
+          CSV_DIV = document.getElementById("popup_csv");
+          TEXT_DIV = document.getElementById("popup_text");
+          TITLE_DIV = document.getElementById("popup_title");
+          OpenBBMain(window.plotly_figure, CHART_DIV, CSV_DIV, TEXT_DIV, TITLE_DIV);
         }
       }, 20);
     </script>