Feature/In-Chart Volume, Streamlit TA Indicators #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![reviewpad[bot]](https://avatars.githubusercontent.com/in/196990?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…r/OpenBBTerminal into feature/volume-inchart
reviewpad
bot
added
feat XL
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4467 +/- ##
==========================================
Coverage ? 55.26%
==========================================
Files ? 584
Lines ? 53365
Branches ? 0
==========================================
Hits ? 29492
Misses ? 23873
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jmaslek
approved these changes
Mar 21, 2023
jmaslek
pushed a commit
that referenced
this pull request
Apr 13, 2023
* init * rename `add_stock_volume` to `add_inchart_volume` in OpenBBFigure class * ruff * poetry lock, req txt files * fix: ma indicator not in list, connectgaps=true for subtickers * improved forecasting streamlit * added past_cov_legend next to explainability plot * Update base.py * updates * Remove deprecated currencies dashboard and it's dependency * Revert import statement deletion * Lint docstrings and delete unused assets * Fix forecast voila dashboard * Fix futures voila dashboard * Remove broken crypto prices dashboard * Remove vsurf dashboard because of over-verbose yfinance error messages * Fix chains dashboard chart title positioning * Remove i18n entries for deleted dashboards * streamlit cmdline fix for macs/conda * Update reddit_model.py * mypy, fixed removed `load_dotenv_and_reload_configs` in `website\controller_doc_classes.py` * readded rust install on CLI for linux in case cache gets cleared * Update forex_helper.py * Update test_load[60-YahooFinance].csv * Update test_call_func[call_sec-marketwatch_view.sec_filings-other_args37-called_with37].yaml * deps * sdk generation tests, trailmap fixes * Revert "sdk generation tests, trailmap fixes" This reverts commit 2575784. * Revert "Revert "sdk generation tests, trailmap fixes"" This reverts commit 5cb0ce0. * improve ta-multi, add title/legends to fred_view * Update ta_controller.py * ruff * Update helper_funcs.py * Update yfinance_view.py * Update helper_funcs.py * change executable parent paths to REPOSITORY_DIRECTORY * fix distorted candlestick plots when freq is weekly/month, fix demark * fix yaxis click handler * Update popups.js * Update popups.js * Update popups.js * Update volatility_plugin.py --------- Co-authored-by: Theodore Aptekarev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4541
Fixes #4542
How has this been tested?
Checklist:
feature/feature-nameorhotfix/hotfix-name.Others