Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stocks/load --file from anywhere #4410

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Allow stocks/load --file from anywhere #4410

merged 4 commits into from
Mar 6, 2023

Conversation

montezdesousa
Copy link
Contributor

Description

To test:

  • stocks/load spy --export spy.csv + stocks/load --file spy.csv --ticker spy
  • move "spy.csv" to anywhere in your pc + stocks/load --file [full/path/to/spy.csv]

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the bug Fix bug label Mar 6, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 6, 2023
@jmaslek jmaslek merged commit f2316b1 into develop Mar 6, 2023
@jmaslek jmaslek deleted the hotfix/issue4354 branch March 6, 2023 20:25
@colin99d colin99d mentioned this pull request Mar 17, 2023
10 tasks
jmaslek added a commit that referenced this pull request Apr 13, 2023
* allow load file from anywhere

* ruff

---------

Co-authored-by: James Maslek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Stocks/load --export puts the file in a path that is not discoverable by stocks/load --file
2 participants