Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User UUID to use the designated column instead #4299

Merged
merged 23 commits into from
Feb 22, 2023
Merged

User UUID to use the designated column instead #4299

merged 23 commits into from
Feb 22, 2023

Conversation

hjoaquim
Copy link
Contributor

The User UUID was being logged into the message column - this PR fixes that by using the designated column, userId.

Reminder, our logs are csv files with columns %(levelname)s-%(appName)s-%(commitHash)s-%(appId)s-%(sessionId)s-%(userId)s-%(asctime)s-%(name)s-%(funcName)s-%(lineno)s-%(message)s separated by |

image

@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 20, 2023
@hjoaquim hjoaquim added the analytics Logging and analytics label Feb 20, 2023
@montezdesousa montezdesousa mentioned this pull request Feb 22, 2023
Merged
15 tasks
@hjoaquim hjoaquim merged commit a054e5d into develop Feb 22, 2023
@hjoaquim hjoaquim deleted the feature/uuid-logs branch February 22, 2023 14:22
jmaslek added a commit that referenced this pull request Apr 13, 2023
@hjoaquim @jmaslek
User UUID to use the designated column instead (#4299)
6eadebf 
* token generation on the terminal

* revoke and show commands

* uuid on the right column

* adding logs to the account commands

* login info at this point does not make sense anymore

* get_user_uuid function

* log formatter to use get_user_uuid function

* ruff + black

* fix tests

* fix tests

---------

Co-authored-by: James Maslek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaslek jmaslek jmaslek approved these changes

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

@tehcoderer tehcoderer Awaiting requested review from tehcoderer

@Chavithra Chavithra Awaiting requested review from Chavithra

Assignees
No one assigned
Labels
analytics Logging and analytics feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjoaquim @jmaslek