Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds shroom command and removes old ones #4246

Merged
merged 31 commits into from
Apr 28, 2023
Merged

Adds shroom command and removes old ones #4246

merged 31 commits into from
Apr 28, 2023

Conversation

jose-donato
Copy link
Contributor

@jose-donato jose-donato commented Feb 15, 2023

Addresses both #2764 and #3943

  • removes old commands (flipside remove/renamed the tables we were using for those commands)
  • adds new command that allows to perform any flipsidecrypto query

Fixes #3943

much more work can be done here:

  • prettify tables (detect if number and format)
  • allow users to display in chart (maybe wait until plotly PR is merged)
  • add templates of sql queries that users can use

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Feb 15, 2023
@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat S Small T-Shirt size Feature labels Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 21.56% and project coverage change: -0.15 ⚠️

Comparison is base (df9a154) 58.29% compared to head (b1ddb51) 58.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4246      +/-   ##
===========================================
- Coverage    58.29%   58.15%   -0.15%     
===========================================
  Files          588      588              
  Lines        53666    53643      -23     
===========================================
- Hits         31283    31194      -89     
- Misses       22383    22449      +66     
Impacted Files Coverage Δ
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...bb_terminal/core/sdk/models/portfolio_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <ø> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
...bb_terminal/dashboards/stream/streamlit_helpers.py 0.00% <0.00%> (ø)
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jose-donato jose-donato requested a review from jmaslek March 30, 2023 22:19
Comment on lines 48 to 51
if raw:
console.print(df)
else:
print_rich_table(df.head(limit))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont think this needs a raw input. raw differentiates between showing a chart and a table

Comment on lines 48 to 51
if raw:
console.print(df)
else:
print_rich_table(df.head(limit))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also limit is an argument. with the interactive, cropping here will only show a small amount

Comment on lines 53 to 58
export_data(
export,
os.path.dirname(os.path.abspath(__file__)),
"query",
df,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sheet name argument

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query -h does not print help text

2023 Apr 27, 16:05 (🐛) /crypto/onchain/ $ query -h

usage: query -q QUERY [QUERY ...] [-h] [--export EXPORT] [--sheet-name SHEET_NAME [SHEET_NAME ...]] [-l LIMIT]
query: error: the following arguments are required: -q/--query

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llstm

@jmaslek jmaslek added this pull request to the merge queue Apr 28, 2023
Merged via the queue into develop with commit c603a36 Apr 28, 2023
@jmaslek jmaslek deleted the feature/shroom branch May 1, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
4 participants