Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bad yFinance candles with auto_adjust=True #4231

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

deeleeramone
Copy link
Contributor

Fix for #4221 when --source YahooFinance for /stocks/load

Adds two arguments to yf.download in stocks_model.py:

auto_adjust = True
actions = True

Before:

Screenshot 2023-02-13 at 12 39 51 PM

After:
Screenshot 2023-02-13 at 12 38 36 PM

@deeleeramone deeleeramone added bug Fix bug dependencies Work related to dependencies labels Feb 13, 2023
@deeleeramone deeleeramone requested a review from jmaslek February 13, 2023 20:42
@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 13, 2023
@deeleeramone deeleeramone linked an issue Feb 13, 2023 that may be closed by this pull request
@jmaslek jmaslek merged commit d6ab000 into develop Feb 14, 2023
@jmaslek jmaslek deleted the hotfix/yfinance-stocks-download branch February 14, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug dependencies Work related to dependencies feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Stocks/candle - Candle is messed up.
2 participants