Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flake8-simplify #4227

Merged
merged 9 commits into from
Feb 21, 2023
Merged

Added flake8-simplify #4227

merged 9 commits into from
Feb 21, 2023

Conversation

colin99d
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XL Extra Large feature label Feb 13, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

@piiq
Copy link
Contributor

piiq commented Feb 14, 2023

are you sure @colin99d ?

@colin99d
Copy link
Contributor Author

Are you asking whether I am sure this is a good linter to have, or whether I am sure that the code works?

@piiq
Copy link
Contributor

piiq commented Feb 14, 2023

are you sure that you want 96 files where code related to the logic has been changed to be reviewed in 1 PR?=)

@piiq
Copy link
Contributor

piiq commented Feb 14, 2023

the linter is good, i'll take it=)

@colin99d
Copy link
Contributor Author

95% of the changes are an autofixer. If you would prefer I do it another way, or break it off into autofixer and non autofixer PRs, let me know.

@colin99d
Copy link
Contributor Author

Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

reviewpad[bot]
reviewpad bot previously requested changes Feb 21, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

@jmaslek jmaslek merged commit cebf454 into develop Feb 21, 2023
@jmaslek jmaslek deleted the feature/flake8-simplify branch February 21, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants