-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flake8-simplify #4227
Added flake8-simplify #4227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency tree has been changed. Please update requirements.txt and requirements-full.txt
are you sure @colin99d ? |
Are you asking whether I am sure this is a good linter to have, or whether I am sure that the code works? |
are you sure that you want 96 files where code related to the logic has been changed to be reviewed in 1 PR?=) |
the linter is good, i'll take it=) |
95% of the changes are an autofixer. If you would prefer I do it another way, or break it off into autofixer and non autofixer PRs, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency tree has been changed. Please update requirements.txt and requirements-full.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency tree has been changed. Please update requirements.txt and requirements-full.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency tree has been changed. Please update requirements.txt and requirements-full.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency tree has been changed. Please update requirements.txt and requirements-full.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency tree has been changed. Please update requirements.txt and requirements-full.txt
Description
How has this been tested?
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others