Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect column label in nasdaq_model.py #4063

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Fix incorrect column label in nasdaq_model.py #4063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d8682a
Fix incorrect column label in nasdaq_model.py
peter-oroszvari Jan 29, 2023
1120fb5
Merge branch 'develop' into develop
jmaslek Jan 30, 2023
8c7139b
Update tests
jmaslek Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openbb_terminal/economy/nasdaq_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def get_economic_calendar(

calendar = calendar.rename(
columns={
"gmt": "Time (GMT)",
"gmt": "Time (ET)",
"country": "Country",
"eventName": "Event",
"actual": "Actual",
Expand Down
2 changes: 1 addition & 1 deletion tests/openbb_terminal/economy/csv/test_nasdaq_model/test_get_economic_calendar.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
,Time (GMT),Country,Event,Actual,Consensus,Previous,Date
,Time (ET),Country,Event,Actual,Consensus,Previous,Date
0,08:30,United States,Continuing Jobless Claims,"1,385K","1,375K","1,364K",2022-10-20
1,08:30,United States,Initial Jobless Claims,214K,230K,226K,2022-10-20
2,08:30,United States,Jobless Claims 4-Week Avg.,212.25K,-,211.00K,2022-10-20
Expand Down
1 change: 0 additions & 1 deletion tests/openbb_terminal/economy/txt/test_nasdaq_view/test_display_big_mac_index[False].txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@

1 change: 0 additions & 1 deletion tests/openbb_terminal/economy/txt/test_nasdaq_view/test_display_big_mac_index[True0].txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ Date
2015-07-31 2.751032 3.065134 3.922265
2015-01-31 2.806361 3.252033 4.318705
2014-07-31 2.826189 2.570773 4.814145

1 change: 0 additions & 1 deletion tests/openbb_terminal/economy/txt/test_nasdaq_view/test_display_big_mac_index[True1].txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ Date
2015-07-31 2.751032 3.065134 3.922265
2015-01-31 2.806361 3.252033 4.318705
2014-07-31 2.826189 2.570773 4.814145

8 changes: 4 additions & 4 deletions tests/openbb_terminal/economy/txt/test_nasdaq_view/test_display_economic_calendar.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Time (GMT) Country Event Actual Consensus Previous Date
0 08:30 United States Continuing Jobless Claims 1,385K 1,375K 1,364K 2022-10-20
1 08:30 United States Initial Jobless Claims 214K 230K 226K 2022-10-20
2 08:30 United States Jobless Claims 4-Week Avg. 212.25K - 211.00K 2022-10-20
Time (ET) Country Event Actual Consensus Previous Date
0 08:30 United States Continuing Jobless Claims 1,385K 1,375K 1,364K 2022-10-20
1 08:30 United States Initial Jobless Claims 214K 230K 226K 2022-10-20
2 08:30 United States Jobless Claims 4-Week Avg. 212.25K - 211.00K 2022-10-20