Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix M1 build #4010

Merged
merged 8 commits into from
Jan 18, 2023
Merged

Fix M1 build #4010

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
80dfd9a
Fix plot look when using eval and add query to choices (#3881)
montezdesousa Jan 6, 2023
fc58757
Lock ruff version so that new lints dont break our CI (#3905)
colin99d Jan 9, 2023
8c39dbc
Merge remote-tracking branch 'OpenBB-finance/main' into develop
hjoaquim Jan 18, 2023
cb2798e
Merge remote-tracking branch 'OpenBB-finance/develop' into develop
hjoaquim Jan 18, 2023
4036a5c
adding xgboost explicitly
hjoaquim Jan 18, 2023
ffac47e
Merge branch 'develop' into hotfix/fix-m1-build
hjoaquim Jan 18, 2023
7bf3fed
testing juan sugestion
hjoaquim Jan 18, 2023
c4d0a31
removing unncessary stuff that the hook deals with
hjoaquim Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build/pyinstaller/terminal.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ added_files = [
(os.path.join(pathex, "blib2to3", "PatternGrammar.txt"), "blib2to3"),
]


if is_darwin and os.path.exists(os.path.join(pathex, "xgboost")):
added_files.append((os.path.join(pathex, "xgboost"), "xgboost"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the hook replace this? @tehcoderer

Copy link
Contributor

@tehcoderer tehcoderer Jan 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sir you can remove that cause it'll run with this
image


# Python libraries that are explicitly pulled into the bundle
hidden_imports = [
"sklearn.utils._cython_blas",
Expand Down