Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Gitflow #3899

Merged
merged 4 commits into from
Jan 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ env:
on:
push:
branches:
- 'feature/*'
- 'hotfix/*'
- "feature/*"
- "hotfix/*"
- 'release/[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?'

# Cancel previous runs that are not yet completed.
Expand All @@ -21,7 +21,7 @@ concurrency:

jobs:
code-linting:
name: Running General Linting Tools
name: General Code Linting
runs-on: ubuntu-latest
steps:
- name: Checkout Code
Expand All @@ -39,8 +39,9 @@ jobs:
key: ${{ runner.os }}-linting-${{ hashFiles('**/poetry.lock') }}
restore-keys: ${{ runner.os }}-linting-${{ hashFiles('**/poetry.lock') }}

- run: pip install bandit black codespell mypy==0.982 pyupgrade safety pylint==2.15.2 packaging==22 ruff
- run: pip install types-pytz types-requests types-termcolor types-tabulate types-PyYAML types-python-dateutil types-setuptools types-six
- run: |
pip install bandit black codespell mypy==0.982 pyupgrade safety pylint==2.15.2 packaging==22 ruff
pip install types-pytz types-requests types-termcolor types-tabulate types-PyYAML types-python-dateutil types-setuptools types-six
- run: bandit -x ./tests -r . || true
- run: black --diff --check .
- run: codespell --ignore-words-list=commun,statics,ro,zar,zlot,jewl,ba,buil,coo,ether,hist,hsi,mape,navagation,operatio,pres,ser,yeld,shold,ist,varian,datas,ake,creat,vie,hel,ket,toke,certi,buidl,ot,te --quiet-level=2 --skip=./tests,.git,*.css,*.csv,*.html,*.ini,*.ipynb,*.js,*.json,*.lock,*.scss,*.txt,*.yaml,./build/pyinstaller,./website/config.toml
Expand All @@ -52,12 +53,12 @@ jobs:
pylint terminal.py openbb_terminal tests

markdown-link-check:
name: Markdown Linting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
name: Check out the code
- name: Lint Code Base
uses: docker://avtodev/markdown-lint:v1
with:
args: "./*.md ./changelogs/*.md ./openbb_terminal/**/*.md ./discordbot/**/*.md"
name: Markdown Linting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
name: Check out the code
- name: Lint Code Base
uses: docker://avtodev/markdown-lint:v1
with:
args: "./*.md ./changelogs/*.md ./openbb_terminal/**/*.md ./discordbot/**/*.md"
10 changes: 4 additions & 6 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ on:
- main
types: [opened, synchronize]


concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Expand Down Expand Up @@ -45,7 +44,6 @@ jobs:
echo "python-changes=false" >> $GITHUB_OUTPUT
fi


- name: Show Output result for python-changes
run: |
echo "python-changes=${{ steps.python-changes.outputs.python-changes }}"
Expand All @@ -56,8 +54,8 @@ jobs:
runs-on: ubuntu-latest
if: needs.python-changes.outputs.python-changes == 'true'
steps:
- name: Show Output result for python-changes
run: echo "python-changes=${{ needs.python-changes.outputs.python-changes }}"
- name: Checkout Code
uses: actions/checkout@v3

- name: Setup Python 3.9
uses: actions/setup-python@v4
Expand Down Expand Up @@ -153,7 +151,7 @@ jobs:
run: |
source $VENV
python terminal.py

full-test:
name: Full Test Suite - (${{ matrix.python-version }}, ${{ matrix.os }})
needs: [base-test]
Expand Down Expand Up @@ -317,4 +315,4 @@ jobs:

- name: Start Terminal and exit
shell: bash -l {0}
run: python terminal.py
run: python terminal.py
1 change: 0 additions & 1 deletion tests/test_helpers.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import pandas as pd


def no_dfs(args: list, kwargs: dict) -> bool:
"""Returns false if there are in dataframe objects given"""
for item in args:
Expand Down