diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index bba6d0a68342..23870d226d15 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -10,8 +10,8 @@ env: on: push: branches: - - 'feature/*' - - 'hotfix/*' + - "feature/*" + - "hotfix/*" - 'release/[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?' # Cancel previous runs that are not yet completed. @@ -21,7 +21,7 @@ concurrency: jobs: code-linting: - name: Running General Linting Tools + name: General Code Linting runs-on: ubuntu-latest steps: - name: Checkout Code @@ -39,8 +39,9 @@ jobs: key: ${{ runner.os }}-linting-${{ hashFiles('**/poetry.lock') }} restore-keys: ${{ runner.os }}-linting-${{ hashFiles('**/poetry.lock') }} - - run: pip install bandit black codespell mypy==0.982 pyupgrade safety pylint==2.15.2 packaging==22 ruff - - run: pip install types-pytz types-requests types-termcolor types-tabulate types-PyYAML types-python-dateutil types-setuptools types-six + - run: | + pip install bandit black codespell mypy==0.982 pyupgrade safety pylint==2.15.2 packaging==22 ruff + pip install types-pytz types-requests types-termcolor types-tabulate types-PyYAML types-python-dateutil types-setuptools types-six - run: bandit -x ./tests -r . || true - run: black --diff --check . - run: codespell --ignore-words-list=commun,statics,ro,zar,zlot,jewl,ba,buil,coo,ether,hist,hsi,mape,navagation,operatio,pres,ser,yeld,shold,ist,varian,datas,ake,creat,vie,hel,ket,toke,certi,buidl,ot,te --quiet-level=2 --skip=./tests,.git,*.css,*.csv,*.html,*.ini,*.ipynb,*.js,*.json,*.lock,*.scss,*.txt,*.yaml,./build/pyinstaller,./website/config.toml @@ -52,12 +53,12 @@ jobs: pylint terminal.py openbb_terminal tests markdown-link-check: - name: Markdown Linting - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - name: Check out the code - - name: Lint Code Base - uses: docker://avtodev/markdown-lint:v1 - with: - args: "./*.md ./changelogs/*.md ./openbb_terminal/**/*.md ./discordbot/**/*.md" \ No newline at end of file + name: Markdown Linting + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + name: Check out the code + - name: Lint Code Base + uses: docker://avtodev/markdown-lint:v1 + with: + args: "./*.md ./changelogs/*.md ./openbb_terminal/**/*.md ./discordbot/**/*.md" diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index d58a70199dab..5e3e04193554 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -14,7 +14,6 @@ on: - main types: [opened, synchronize] - concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true @@ -45,7 +44,6 @@ jobs: echo "python-changes=false" >> $GITHUB_OUTPUT fi - - name: Show Output result for python-changes run: | echo "python-changes=${{ steps.python-changes.outputs.python-changes }}" @@ -56,8 +54,8 @@ jobs: runs-on: ubuntu-latest if: needs.python-changes.outputs.python-changes == 'true' steps: - - name: Show Output result for python-changes - run: echo "python-changes=${{ needs.python-changes.outputs.python-changes }}" + - name: Checkout Code + uses: actions/checkout@v3 - name: Setup Python 3.9 uses: actions/setup-python@v4 @@ -153,7 +151,7 @@ jobs: run: | source $VENV python terminal.py - + full-test: name: Full Test Suite - (${{ matrix.python-version }}, ${{ matrix.os }}) needs: [base-test] @@ -317,4 +315,4 @@ jobs: - name: Start Terminal and exit shell: bash -l {0} - run: python terminal.py \ No newline at end of file + run: python terminal.py diff --git a/tests/test_helpers.py b/tests/test_helpers.py index 7820199cf709..dbfc099b9344 100644 --- a/tests/test_helpers.py +++ b/tests/test_helpers.py @@ -1,6 +1,5 @@ import pandas as pd - def no_dfs(args: list, kwargs: dict) -> bool: """Returns false if there are in dataframe objects given""" for item in args: