Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect users to correct installation tab based on OS #3676

Merged
merged 10 commits into from
Dec 5, 2022

Conversation

jose-donato
Copy link
Contributor

No description provided.

@jose-donato jose-donato added the docs Code documentation label Dec 1, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Dec 1, 2022
@jose-donato jose-donato requested a review from jmaslek December 2, 2022 11:01
@andrewkenreich
Copy link
Contributor

Need a catch all here for random user agent types -

image

This is shown if it isnt found

Copy link
Contributor

@andrewkenreich andrewkenreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other should show Windows

@jose-donato
Copy link
Contributor Author

@andrewkenreich should be good now. nice catch

@andrewkenreich
Copy link
Contributor

looks good to me - @jmaslek you want to review as well?

@jose-donato jose-donato merged commit 389ecc5 into main Dec 5, 2022
@jose-donato jose-donato deleted the agent_detection_installer branch December 5, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants