Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove signatures with volatile date defaults #3385

Merged
merged 145 commits into from
Nov 15, 2022
Merged

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Nov 11, 2022

Description

This PR fixes #3386

Test SDK endpoints and respective terminal cmds:

from openbb_terminal.sdk import openbb
openbb.stocks.ba.cnews("AAPL")
openbb.stocks.dps.ftd("AAPL")
openbb.stocks.dps.ftd("AAPL", chart=True)
openbb.crypto.load("ETH")
openbb.stocks.disc.ipo()
openbb.stocks.disc.dividends("2022-08-10")
openbb.stocks.dd.pt("AAPL")
openbb.stocks.load("AAPL")
openbb.stocks.candle("AAPL")
openbb.stocks.ca.hcorr(similar=["AAPL", "MSFT"], start_date="2022-10-01")
openbb.stocks.ca.hist(similar=["AAPL", "MSFT"], start_date="2022-10-01")
openbb.stocks.ca.volume(similar=["AAPL", "MSFT"], start_date="2022-10-01")
openbb.stocks.fa.mktcap(symbol="AAPL", start_date="2022-10-01")
openbb.stocks.ins.act(symbol="AAPL")
oopenbb.stocks.options.pcr(symbol="AAPL")
openbb.stocks.screener.historical(start_date="2022-10-01")
openbb.crypto.candles(openbb.crypto.load("ETH"))
openbb.economy.events()
openbb.economy.macro()
openbb.economy.macro(chart=True)
openbb.economy.treasury()
openbb.economy.treasury(chart=True)
openbb.crypto.dd.close("ETH")
openbb.forex.hist()
openbb.stocks.ba.trend()
openbb.stocks.ba.hist()
openbb.etf.news("SPY")
openbb.crypto.dd.nonzero("ETH")
openbb.crypto.dd.active("ETH")
openbb.crypto.onchain.hr("ETH")
openbb.crypto.dd.eb("ETH")
openbb.crypto.dd.change("ETH")
openbb.crypto.dd.mcapdom("ETH")
openbb.crypto.dd.get_mt()
openbb.crypto.onchain.btc_supply()
openbb.crypto.onchain.btc_transac()
openbb.crypto.ov.altindex()
openbb.crypto.ov.btcrb()
openbb.crypto.ov.btcrb(chart=True)

Changed date arguments and generate SDK website

@montezdesousa montezdesousa marked this pull request as ready for review November 11, 2022 13:38
@montezdesousa montezdesousa added do not merge Label to prevent pull request merge and removed do not merge Label to prevent pull request merge labels Nov 11, 2022
@montezdesousa montezdesousa added the do not merge Label to prevent pull request merge label Nov 14, 2022
@montezdesousa montezdesousa removed the do not merge Label to prevent pull request merge label Nov 14, 2022
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Nov 15, 2022
@montezdesousa montezdesousa removed the feat M Medium T-Shirt size feature label Nov 15, 2022
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Nov 15, 2022
@montezdesousa montezdesousa merged commit f1de004 into main Nov 15, 2022
@montezdesousa montezdesousa deleted the signature_dates branch November 15, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Function signatures with volatile defaults induce website changes if run in different days
4 participants