New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3236 #3250

Merged

DidierRLopes merged 1 commit into OpenBB-finance:main from victortangggg:fix_3236

Nov 1, 2022

Contributor

victortangggg commented Nov 1, 2022

fix /sources/news sources display error. (#3236)

Description

error:

fix:

How has this been tested?

i used vscode debugger.
found that there's no default value for sources in the namespace parser.

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

Make sure affected commands still run in terminal
Ensure the SDK still works
Check any related reports

Checklist:

Update our Hugo documentation following these guidelines.
Update our tests following these guidelines.
Make sure you are following our CONTRIBUTING guidelines.
If a feature was added make sure to add it to the corresponding scripts file.

Others

I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.


          fix #3236

3ae4400

fix None sources which gave error

DidierRLopes added the bug label

DidierRLopes approved these changes

View reviewed changes

Collaborator

DidierRLopes commented Nov 1, 2022

Thank you a lot @victortangggg 🙏🏽

Welcome to the team!

DidierRLopes approved these changes

View reviewed changes

DidierRLopes merged commit 2a676d2 into OpenBB-finance:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug