Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker revisions 2.0 #2714

Merged
merged 7 commits into from
Oct 5, 2022
Merged

Docker revisions 2.0 #2714

merged 7 commits into from
Oct 5, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Oct 5, 2022

Description

The current Docker setup builds a bunch of unused images, which wastes a lot of time. This PR renames the original docker-compose to docker-compose-full, and makes the new docker-compose much lighter.

Also. A lot of people have stressed the fact that Artem explained to them that we need multiple images to speed up creation. That is 100% correct, this ONLY removes images not in the dependency chain for openbbterminal-poetry (the one we have been pushing). These include things for openbb-terminal-full (for developers) and our jupyter branches.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the api still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the docker Docker-related work label Oct 5, 2022
@colin99d colin99d requested review from piiq and DidierRLopes October 5, 2022 08:07
@Chavithra Chavithra self-requested a review October 5, 2022 08:56
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@colin99d colin99d merged commit 2a9e280 into main Oct 5, 2022
@colin99d colin99d deleted the docker2 branch October 5, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants