Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Economy/Macro Y10YD: Adding United_Kingdom, specifically, in a multi-country chart causes bad data, but individually are fine. #3886

Closed
deeleeramone opened this issue Jan 7, 2023 · 1 comment · Fixed by #4078
Assignees
Labels
bug Fix bug

Comments

@deeleeramone
Copy link
Contributor

A strange error occurs from this parameter, but only when the United_Kingdom is added to the mix.

macro --parameters Y10YD --countries Italy,Germany,France

Screenshot 2023-01-06 at 5 26 59 PM

Drawing the UK line works fine by itself

macro --parameters Y10YD --countries United_Kingdom

Screenshot 2023-01-06 at 5 29 01 PM

macro --parameters Y10YD --countries Italy,Germany,France,United_Kingdom

But, combining with the first chart makes some weird choices:

Screenshot 2023-01-06 at 5 31 03 PM

It isn't because of misaligned starting points:

macro --parameters Y10YD --countries Italy,Germany,France,United_States
Screenshot 2023-01-06 at 5 34 43 PM

@deeleeramone deeleeramone added the bug Fix bug label Jan 7, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Jan 7, 2023

This is quite interesting. EconDB gives the UK data daily and the other ones end of month.

We generate the dataframe as a multi index from a dictionary (country_data_df = pd.DataFrame.from_dict(country_data, orient="index").stack().to_frame()), so we will likely need to change that to some kind of outer merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants