Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Store API Keys when running via Docker #3585

Closed
Shivamp629 opened this issue Nov 25, 2022 · 1 comment
Closed

[IMPROVE] Store API Keys when running via Docker #3585

Shivamp629 opened this issue Nov 25, 2022 · 1 comment
Labels
docker Docker-related work

Comments

@Shivamp629
Copy link

What's the feature that should be improved?
API Keys should be saved to storage when running the terminal via Docker. Currently, if you run the container and set keys, they're wiped when you restart the container and have to set them all over again.

Describe how you would like the feature improved
When running and stopping the docker container, API keys should be persisted on disc so that they do not need to be set again.

Possibly describe the ideal way to improve this
If you have thought about how you would do it, add it here.

Additional information
Add any other information or screenshots about the feature improvement.

@piiq piiq added the docker Docker-related work label Feb 10, 2023
@piiq
Copy link
Contributor

piiq commented Feb 10, 2023

Hey 👋

This was addressed in December 2022 with the updates to key management and the introduction of the ~/.openbb_terminal/.env file.

The issue of keys not being available in the container was resolved by #3545 #3666 and subsequent PRs.

When using docker you can mount that file into the container to have your keys available

We have a docker-compose file that helps you launch the container with a simpler command (compared to a docker run)

curl -o docker-compose.yaml https://raw.githubusercontent.com/OpenBB-finance/OpenBBTerminal/main/build/docker/docker-compose.yaml

docker compose run openbb

It mounts your key/settings file and your OpenBBUserData folder into the container
image

@piiq piiq closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker-related work
Projects
None yet
Development

No branches or pull requests

2 participants