Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot to auto add closed-by-bot label when bot close stale issue/PR #81

Open
pllim opened this issue Aug 1, 2019 · 5 comments
Open

bot to auto add closed-by-bot label when bot close stale issue/PR #81

pllim opened this issue Aug 1, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@pllim
Copy link
Contributor

pllim commented Aug 1, 2019

Currently, something is not ideal in the cron job setting such that the bot is unable to auto label "closed-by-bot" to stale issue or PR that it closes. A workaround is for the bot to detect a "close" event live (not cron) and auto label those things.

@pllim pllim added the bug Something isn't working label Aug 1, 2019
@pllim
Copy link
Contributor Author

pllim commented Aug 1, 2019

@astrofrog identified for the auto labeling stuff (astropy/astropy-bot#106) that forked repo does not have all the labels in the upstream repo, but I don't think that is a problem for this one, as the label to add is already known, but it is just that the action of setting label does not do anything. So I think it is still some permission problem with cron job.

@pllim
Copy link
Contributor Author

pllim commented Aug 7, 2019

Attempt started in astropy/astropy-bot#110 . Since it is specific to astropy core, I did not put it here.

@bsipocz
Copy link
Member

bsipocz commented Aug 7, 2019

Hmm, adding a label for auto closure seems to be generically preferable to me, so could it still live in baldrick and being customizable downstream about the specifics of the kind of label it should apply?

@pllim
Copy link
Contributor Author

pllim commented Aug 8, 2019

AFAIK, the stale scripts only run for astropy core. 🤷‍♀️ I am afraid PR is going to be rejected if I submit this to baldrick.

@bsipocz
Copy link
Member

bsipocz commented Aug 8, 2019

I would support it :)

We advertise baldrick as a generic bot, and this is very much a nice generic functionality even if it's not used yet by many projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants