Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ComposedSchema vars incorrectly includes extra properties #8813

Closed
6 tasks
spacether opened this issue Feb 23, 2021 · 0 comments
Closed
6 tasks

[BUG] ComposedSchema vars incorrectly includes extra properties #8813

spacether opened this issue Feb 23, 2021 · 0 comments

Comments

@spacether
Copy link
Contributor

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

composed schemas incorrectly include extra properties when the should only include self schema properties
It looks like they include composed schema properties
Keeping these separate is necessary for correct json schema validation. One must check that:

  • types conform to any constraints at the composed schema level
  • validations conform to any constraints at the composed schema level
  • payload properties match properties defined at the composed schema level
  • additional properties match additionalProperties constraints at the composed schema level (omitted additionalProperties allows any type to be ingested)
  • defined composed schemas must validate to the payload
openapi-generator version

master 3.1.0

OpenAPI declaration file content or url
Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix
@spacether spacether changed the title [BUG] ComposedSchema vars incorrectly include extra properties [BUG] ComposedSchema vars incorrectly includes extra properties Feb 23, 2021
@spacether spacether linked a pull request Feb 24, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant