Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] First-time contributor labeling and core team tagging #7290

Open
jimschubert opened this issue Aug 25, 2020 · 2 comments
Open

[REQ] First-time contributor labeling and core team tagging #7290

jimschubert opened this issue Aug 25, 2020 · 2 comments

Comments

@jimschubert
Copy link
Member

Is your feature request related to a problem? Please describe.

Some technical committees have slow response times, which could potentially be off-putting to new contributors. I think it would be helpful to have a core team member in the loop on all first-time contributors.

Describe the solution you'd like

If possible, label pull requests from first-time contributors as such and assign @OpenAPITools/openapi-generator-core-team as reviewer or assignee.

Describe alternatives you've considered

Rather than relying solely on technical committees, maybe we could have a "community" group of contributors who regularly respond to a variety of pull requests. Perhaps as a subset of members of the collaborators group (@macjohnny and @ybelenko are examples of folks who I've seen do it)

Additional context

See #6806 for an example of a new contributor who had pinged 5 times over 3 weeks without response. Additionally, we may want to consider explaining our pull request process because it may not be obvious to contributors that pinging multiple times in a short period could be counter-productive to getting a response.

@ybelenko
Copy link
Contributor

Sounds good, but how should I review code made with languages that I never seen before?)

Should I write something like:

Looks good to me, I like your 4 spaced indentations. I hope this code does work as expected. 👍

@jimschubert
Copy link
Member Author

Haha. @ybelenko I didn't mean to make it sound like I was volunteering you! I just meant to use you as an example because you focus on PHP/MySQL, but I've also seen you respond on other generator pull requests (like Markdown, for example).

I've found that a lot of times it's easy to tell if something is a potential breaking change (parameters are moved around, template files are renamed, or generator arg defaults are changed or deprecated with no user notice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants