Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-symfony] Generated Controller uses an undefined property #577

Closed
dimitriyremerov opened this issue Jul 16, 2018 · 0 comments · Fixed by #578
Closed

[php-symfony] Generated Controller uses an undefined property #577

dimitriyremerov opened this issue Jul 16, 2018 · 0 comments · Fixed by #578

Comments

@dimitriyremerov
Copy link
Contributor

dimitriyremerov commented Jul 16, 2018

Description

Controller does not have container property which is being accessed in the code.
swagger-api/swagger-codegen#6842 introduced access to container property of the BaseController. At this point Controller did not have container property anymore since the inheritance from the Base Symfony Controller was removed in swagger-api/swagger-codegen#6615. These changes were incompatible and now any generated php-symfony code will fail should any exception be thrown down the stack and caught by the Controller.
Example of an invalid Controller: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/Controller.php#L149

openapi-generator version

3.2, 4.0, master

openapi declaration file content or url

Any swagger/openapi declaration file, example: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/2_0/petstore.yaml

Command line used for generation

java -jar openapi-generator.jar generate -i /api/swagger.yml -l php-symfony -o /src

Steps to reproduce

Any generated php-symfony code is invalid now and will fail should any exception be thrown.

  1. Generate any php-symfony code from any swagger configuration
  2. Throw an exception anywhere during the business logic execution.
Related issues/PRs

Issue introduced in: swagger-api/swagger-codegen#6842
Related PR (removal of BaseController inheritance): swagger-api/swagger-codegen#6615

Suggest a fix/enhancement

PR open: #578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants