Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unalias schema in getTypeDeclaration when not generating model for alias #4563

Closed
wing328 opened this issue Nov 21, 2019 · 2 comments
Closed

Unalias schema in getTypeDeclaration when not generating model for alias #4563

wing328 opened this issue Nov 21, 2019 · 2 comments
Labels
help wanted Issue: Bug
Milestone
4.3.0

Comments

@wing328
Copy link
Member

wing328 commented Nov 21, 2019

Description

Defining a schema for an array type, and referencing it as the items type in another array doesn't generate valid code. It happened for me in Java and go-experimental that I'm using, but might be the case for other languages as well.

#4527 fixes the issue for Go and Java. We will need to do it for all other generators.

If anyone wants to help out, please reply to let us know.

openapi-generator version

Latest master

OpenAPI declaration file content or url

#4362 (comment)

Related issues/PRs

#4527
@wing328 wing328 added this to the 4.2.2 milestone Nov 21, 2019
@wing328 wing328 mentioned this issue Nov 21, 2019
Merged
5 tasks
@wing328 wing328 modified the milestones: 4.2.2, 4.2.3 Dec 2, 2019
@wing328 wing328 modified the milestones: 4.2.3, 5.0.0, 4.3.0 Jan 31, 2020
@amakhrov amakhrov mentioned this issue Feb 5, 2020
Closed
6 tasks
@amakhrov
Copy link
Contributor

amakhrov commented Feb 7, 2020

@wing328 Looks like there is an attempt to address that - #4981

@wing328
Copy link
Member Author

wing328 commented Mar 3, 2020

Fixed via #4981

@wing328 wing328 closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issue: Bug
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
2 participants
@wing328 @amakhrov