Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Upgrade to tokio 0.2 and related async/await features #3865

Closed
dbcfd opened this issue Sep 9, 2019 · 5 comments · Fixed by #6244
Closed

[REQ] Upgrade to tokio 0.2 and related async/await features #3865

dbcfd opened this issue Sep 9, 2019 · 5 comments · Fixed by #6244

Comments

@dbcfd
Copy link

dbcfd commented Sep 9, 2019

Is your feature request related to a problem? Please describe.

The tokio ecosystem is currently migrating to std::future::Future and async/await support. This should land in rust 1.39 (currently stable in nightly)

Describe the solution you'd like

Upgrade to appropriate versions for tokio and hyper that make use of std::future::Future and async/await

Describe alternatives you've considered

Tokio 0.2 is not compatible with older hyper versions (pre hyper 0.13). One possibility is to try and use runtime and tide, but that is significantly more of a change.

@dbcfd
Copy link
Author

dbcfd commented Sep 9, 2019

Not seeing how to add label client:rust or server:rust

@richardwhiuk
Copy link
Contributor

For Rust Server, my plan is to upgrade to tokio 0.2 and hyper 0.13 when Rust 1.39 stabilises in November, which adds non-nightly support for async/await.

@kanekv
Copy link

kanekv commented Nov 12, 2019

@richardwhiuk 1.39 is released! What is your plan with upgrade? Do you need help?

@dbcfd
Copy link
Author

dbcfd commented Nov 12, 2019

@kanekv See #4210 The client was was fairly far along, but if someone wants to revisit it again with latest hyper/reqwest, that would be helpful. Focusing on server right now. Make sure to use github master for hyper, since there are significant changes from the released alpha version.

@richardwhiuk
Copy link
Contributor

richardwhiuk commented Nov 14, 2019

@kanekv There's an MR open at #4210

Ideally, we'd like tokio 0.2 and hyper 0.13 to stabilise.

In the short term, you can use Compat::new() and .compat() (from futures 0.3 with the compat feature) in the business logic to allow use of async/await.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants