Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][KOTLIN] Sanitize names of the adapter variables in anyOf and oneOf model template to avoid compilation errors #19981

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CaptainAye
Copy link
Contributor

@CaptainAye CaptainAye commented Oct 26, 2024

Pr introduces sanitizing of the adapter... names in the oneOf and anyOf model templates in order to avoid incorrect names being generated.
The root cause of this issue comes from the fact that Kotlin generator uses canonical names for type mappings and thus {{dataType}} variable is a canonical name with dots. It is then used for variable names generation.
Sanitizing of the names will be enough to fix #19942 but the type mappings problem should also be addressed imo.
It seems that other generators (i.e. java) are not having this issue.

During the preparation of this fix, I also realized that validateJsonElement methods are also missing in oneOf and anyOf classes, which would also cause the compilation errors. I fixed this issue as well in the scope of this pr.

Technical Kotlin Committee:
@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kotlin generator: generateOneOfAnyOfWrappers=true leads to broken code
1 participant