Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CodegenProperty#isInherited not set right #11845

Closed
5 of 6 tasks
devhl-labs opened this issue Mar 10, 2022 · 2 comments
Closed
5 of 6 tasks

[BUG] CodegenProperty#isInherited not set right #11845

devhl-labs opened this issue Mar 10, 2022 · 2 comments
Labels
Issue: Bug

Comments

@devhl-labs
Copy link
Contributor

Some properties do not have isInherited set correctly. See modules\openapi-generator\src\test\resources\3_0\allOf.yaml Child properties Type, LastName, FirstName will have isInherited set to false when it should be true. This is in csharp-netcore, any library.

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
@ahmednfwela
Copy link
Contributor

I have also encountered this problem on #12295 , will make a PR to solve it

@devhl-labs
Copy link
Contributor Author

Fantastic. I have a hot fix in the CSharpNetCoreClientCodegen that can be removed once this is fixed. The url for this issue is in the code.

@BitcoinOutput BitcoinOutput mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devhl-labs @ahmednfwela