Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: linux_rpc_demo: Do not access members of rpmsg_endpoint #566

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

glneo
Copy link
Contributor

@glneo glneo commented Mar 15, 2024

The contents of this struct are internal to the RPMsg layer. Access should only happen using accessor functions.

@glneo glneo force-pushed the apps-endpoint-name branch from 742ad0c to 3a77e74 Compare March 15, 2024 19:14
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong rule that indicates that ept is an internal structure.
Nevertheless you are right better to consider it when possible.

@arnopo arnopo requested review from edmooring and tnmysh March 18, 2024 13:39
glneo added 2 commits March 19, 2024 08:59
The contents of this struct are internal to the RPMsg layer. Access
should only happen using accessor functions.

Signed-off-by: Andrew Davis <[email protected]>
If we do not use the endpoint there is no need to check it for NULL,
remove this check.

Signed-off-by: Andrew Davis <[email protected]>
@glneo glneo force-pushed the apps-endpoint-name branch from 3a77e74 to 43ba239 Compare March 29, 2024 16:32
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo arnopo requested a review from tnmysh April 9, 2024 08:02
@arnopo arnopo merged commit 20ba140 into OpenAMP:main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants