Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number 'zn' fail. #65

Open
BartSaelen opened this issue Apr 4, 2016 · 2 comments
Open

number 'zn' fail. #65

BartSaelen opened this issue Apr 4, 2016 · 2 comments

Comments

@BartSaelen
Copy link

In some cases, CRAB returns a number 'zn'. ex:

{  
    "status":{  
      "naam":"inGebruik",
      "definitie":null,
      "id":"3"
    },
    "id":3350022,
    "label":"zn"
  }

If this id is used for a call to 'GetPostkantonByHuisnummerId', an empty response is returned. This results in a GatewayResourceNotFoundException.
see:
https://github.com/OnroerendErfgoed/crabpy/blob/master/crabpy/gateway/crab.py#L890

Not sure if this is something we should fix or AGIV should return something?

@BartSaelen
Copy link
Author

Full address used:
country: België
city: Houffalize
postalcode: 6666
street: Achouffe
number: zb

@BartSaelen BartSaelen changed the title validatie met adres met huisnummer 'zn' faalt. nummer 'zn' fail. Apr 4, 2016
@BartSaelen BartSaelen changed the title nummer 'zn' fail. number 'zn' fail. Apr 4, 2016
@koenedaele
Copy link
Member

So, we are calling GetPostkantonByHuisnummerId with a HuisnummerId that was provided to us by CRAB (and so should be valid), but CRAB can't give us the postkanton for this HuisnummerId, meaning that either the huisnummer doesn't actually exist or that CRAB can't find the postcode for this huisnummer.

I just tried looking up the HuisnummerId at https://geo.onroerenderfgoed.be/crab/huisnummers/3350022, but this also causes an Internal Server Error. So this would indicate that there is some problem with the Huisnummer. If it didn't exist, we would receive a ResourceGatewayNotFound that gets turned into a 404 (https://github.com/OnroerendErfgoed/crabpy_pyramid/blob/master/crabpy_pyramid/views/crab.py#L178). Need to debug further, but I'm assuming this problem will be more on the AGIV side than ours.

Where did we get the info from? What call returned this data? Or is this information that came out of the GRB webservice (which isn't synced with CRAB apparently)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants