From 8e3a666d1c87a28f0831c1f9f95555e41343ab07 Mon Sep 17 00:00:00 2001 From: Wick Date: Sun, 25 Feb 2024 21:08:06 +0800 Subject: [PATCH] chore(reactivity): consistent variable naming (#10350) --- packages/reactivity/src/baseHandlers.ts | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/reactivity/src/baseHandlers.ts b/packages/reactivity/src/baseHandlers.ts index a1b3003a5e7..7cee7aa9bd5 100644 --- a/packages/reactivity/src/baseHandlers.ts +++ b/packages/reactivity/src/baseHandlers.ts @@ -89,26 +89,26 @@ function hasOwnProperty(this: object, key: string) { class BaseReactiveHandler implements ProxyHandler { constructor( protected readonly _isReadonly = false, - protected readonly _shallow = false, + protected readonly _isShallow = false, ) {} get(target: Target, key: string | symbol, receiver: object) { const isReadonly = this._isReadonly, - shallow = this._shallow + isShallow = this._isShallow if (key === ReactiveFlags.IS_REACTIVE) { return !isReadonly } else if (key === ReactiveFlags.IS_READONLY) { return isReadonly } else if (key === ReactiveFlags.IS_SHALLOW) { - return shallow + return isShallow } else if (key === ReactiveFlags.RAW) { if ( receiver === (isReadonly - ? shallow + ? isShallow ? shallowReadonlyMap : readonlyMap - : shallow + : isShallow ? shallowReactiveMap : reactiveMap ).get(target) || @@ -143,7 +143,7 @@ class BaseReactiveHandler implements ProxyHandler { track(target, TrackOpTypes.GET, key) } - if (shallow) { + if (isShallow) { return res } @@ -164,8 +164,8 @@ class BaseReactiveHandler implements ProxyHandler { } class MutableReactiveHandler extends BaseReactiveHandler { - constructor(shallow = false) { - super(false, shallow) + constructor(isShallow = false) { + super(false, isShallow) } set( @@ -175,7 +175,7 @@ class MutableReactiveHandler extends BaseReactiveHandler { receiver: object, ): boolean { let oldValue = (target as any)[key] - if (!this._shallow) { + if (!this._isShallow) { const isOldValueReadonly = isReadonly(oldValue) if (!isShallow(value) && !isReadonly(value)) { oldValue = toRaw(oldValue) @@ -237,8 +237,8 @@ class MutableReactiveHandler extends BaseReactiveHandler { } class ReadonlyReactiveHandler extends BaseReactiveHandler { - constructor(shallow = false) { - super(true, shallow) + constructor(isShallow = false) { + super(true, isShallow) } set(target: object, key: string | symbol) {