Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneSignal fails Lighthouse tests #360

Closed
ghost opened this issue May 24, 2018 · 3 comments
Closed

OneSignal fails Lighthouse tests #360

ghost opened this issue May 24, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented May 24, 2018

Hello,

Is it possible to update some of the OneSignal Code because it fails the Lighthouse tests for accessibility, see below screenshot:

untitled

The two problems are as follows:

  1. No alt-tag

This can be fixed by editing the file found here: https://github.com/OneSignal/OneSignal-Website-SDK/blob/master/src/popover/Popover.ts

Code line: 63

(Just add alt="logo")

  1. The default writing in the CSS doesn't pass WCAG 2.0 (AA) spec.

This can be fixed by editing the file found here: https://github.com/OneSignal/OneSignal-Website-SDK/blob/master/src/stylesheets/popover.scss

Change the CSS color and background from: #4285f4 to a little bit darker blue such as: #1165f1 and it will then pass WCAG 2.0 (AA) giving a ratio of 5.05

I am more than happy to create a Pull Request to make your software pass these simple things.

@jkasten2
Copy link
Member

@ayumihamsaki Pull requests are welcome! The alt could be set to "notification icon" to be a bit more descriptive. I'll have to double check if the color was set to that specific value for any reason but this also sounds like a good change

@ghost
Copy link
Author

ghost commented May 25, 2018

@jkasten2 Let me know what folder to send it to if not the master and I will create a pull request now with the above changes.

@ghost ghost mentioned this issue May 25, 2018
@jkasten2
Copy link
Member

This is now live in the version 150400!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant