You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change the CSS color and background from: #4285f4 to a little bit darker blue such as: #1165f1 and it will then pass WCAG 2.0 (AA) giving a ratio of 5.05
I am more than happy to create a Pull Request to make your software pass these simple things.
The text was updated successfully, but these errors were encountered:
@ayumihamsaki Pull requests are welcome! The alt could be set to "notification icon" to be a bit more descriptive. I'll have to double check if the color was set to that specific value for any reason but this also sounds like a good change
Hello,
Is it possible to update some of the OneSignal Code because it fails the Lighthouse tests for accessibility, see below screenshot:
The two problems are as follows:
This can be fixed by editing the file found here: https://github.com/OneSignal/OneSignal-Website-SDK/blob/master/src/popover/Popover.ts
Code line: 63
(Just add
alt="logo"
)This can be fixed by editing the file found here: https://github.com/OneSignal/OneSignal-Website-SDK/blob/master/src/stylesheets/popover.scss
Change the CSS color and background from:
#4285f4
to a little bit darker blue such as:#1165f1
and it will then pass WCAG 2.0 (AA) giving a ratio of 5.05I am more than happy to create a Pull Request to make your software pass these simple things.
The text was updated successfully, but these errors were encountered: