Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genstrings not working correctly with OBALoc() format variant #664

Open
aaronbrethorst opened this issue Apr 8, 2023 · 1 comment
Open

Comments

@aaronbrethorst
Copy link
Member

The variant of OBALoc that includes a format: parameter isn't being correctly interpreted by genstrings, which is invoked in the extract_strings script. It's not clear based on a cursory glance whether this is something that can be corrected with genstrings, or if we need to just remove this OBALoc variant and do things the hard way with it.

Repro:

  1. Run script/extract_strings
  2. Look at the diff for OBAKit/Strings/en.lproj/Localizable.strings — specifically, look at "data_migration_bulletin.report_summary_number_of_successes" and "data_migration_bulletin.report_summary_number_of_failures"

Expected:

These two keys have the values "%d successful" and "%d failures", respectively.

Actual:

They don't.

@aaronbrethorst
Copy link
Member Author

fyi @ualch9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant