Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StopTime #87

Open
pjpsoares opened this issue Jul 21, 2017 · 4 comments · May be fixed by #88
Open

StopTime #87

pjpsoares opened this issue Jul 21, 2017 · 4 comments · May be fixed by #88

Comments

@pjpsoares
Copy link

I would assume this is not only for StopTime but for every other place that represents date in the same way, but the javadoc is wrong for this. It's not actually the added time after midnight, but the added time after noon minus 12 hours as specified in GTFS.
This could cause some strange behavior regarding timetables when the daylight savings time changes occur.
@sheldonabrown
Copy link
Member

sheldonabrown commented Jul 21, 2017 •
edited
Loading

I'm not sure I follow. The intent of advancing to noon and then back 12 hours is in fact to have consistent handling of timetables during daylight savings changes.

Are you simply suggesting the javadoc is corrected? If so, how about a pull request?

@pjpsoares
Copy link
Author

Yes, suggesting that the javadoc is corrected. Will do the PR.

@sheldonabrown
Copy link
Member

Great! Thanks.

@pjpsoares pjpsoares linked a pull request Jul 24, 2017 that will close this issue
Open
@derhuerst derhuerst mentioned this issue Nov 25, 2021
Open
@derhuerst
Copy link

I'm curious, is there any place in onebusaway-gtfs where the GTFS Time semantics are not obeyed, such as conversion from relative arrival/departure times to absolute ones, e.g. when querying departures at a point in time?

@derhuerst derhuerst mentioned this issue May 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change javadoc for arrival & departure time pjpsoares/onebusaway-gtfs-modules
3 participants
@sheldonabrown @derhuerst @pjpsoares